feat: add initscore flag to !i madd/meta#2223
Merged
codybanman merged 2 commits intoavrae:nightlyfrom Nov 25, 2025
Merged
Conversation
d578a24 to
2e3d22f
Compare
codybanman
requested changes
Nov 3, 2025
Contributor
codybanman
left a comment
There was a problem hiding this comment.
This looks great. I made a note in the code but I think we should apply the -b bonus to the initscore calculation if set.
Also, it would be good to add tests for this. You could add something to tests/e2e/cogs/initTracker_test.py, similar to the existing TestYourStandardInitiative class.
6d6d701 to
6c688fa
Compare
also added -b support for initscore
6c688fa to
bbfef6a
Compare
codybanman
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
initscoreflag to!init maddand!init meta. Uses monster's initiative score (10 + modifier) instead of rolling, as per MM2024 optional rule.Changelog Entry
Added
initscoreflag to!init maddand!init metaas per MM2024 optional rule.Checklist
PR Type
Other