Skip to content

fix: unify beyond sheet duplicate handling for compendium and homebrew spells#2219

Merged
codybanman merged 1 commit intonightlyfrom
fix-homebrew-spell-overriding-prepared
Sep 26, 2025
Merged

fix: unify beyond sheet duplicate handling for compendium and homebrew spells#2219
codybanman merged 1 commit intonightlyfrom
fix-homebrew-spell-overriding-prepared

Conversation

@codybanman
Copy link
Copy Markdown
Contributor

Summary

Fixed inconsistent spell duplicate handling between compendium and homebrew spells in D&D Beyond imports. Previously, homebrew spells would unconditionally overwrite existing spells with the same name, causing unprepared homebrew versions to replace prepared compedium versions. The fix unifies duplicate handling logic so both spell types follow the same rules for prioritizing prepared spells and comparing spell attack bonuses/DCs.

Changelog Entry

Fixed homebrew spells incorrectly overwriting prepared compendium spells during D&D Beyond character import.

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

Copy link
Copy Markdown
Contributor

@tiberius0954 tiberius0954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codybanman codybanman merged commit 39d500f into nightly Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants