Skip to content

fix(dcv2): allow non-standard damage mults#2203

Merged
codybanman merged 2 commits intoavrae:nightlyfrom
LazyDope:dicecloud-resistances
Aug 14, 2025
Merged

fix(dcv2): allow non-standard damage mults#2203
codybanman merged 2 commits intoavrae:nightlyfrom
LazyDope:dicecloud-resistances

Conversation

@LazyDope
Copy link
Copy Markdown
Contributor

@LazyDope LazyDope commented Aug 4, 2025

Summary

Remove check in DCv2 resistance function for standard 5e damage types.

Changelog Entry

Allow non-standard damage types on Dicecloud V2 sheets to be imported.

Checklist

PR Type

  • This PR is a code change that implements a feature request.
  • This PR fixes an issue.
  • This PR adds a new feature that is not an open feature request.
  • This PR is not a code change (e.g. documentation, README, ...)

Other

  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.

raise Exception("You must call get_character() first.")

# only unqiue resistances pls
# only unique resistances pls
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I'd fix that while I was at it lol

@codybanman codybanman merged commit a93afb6 into avrae:nightly Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants