Allow adding/removing Sleeping to sleep/wake bodies#834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In past versions of Avian, adding/removing
Sleepingmanually was supported as a way to sleep or wake up a rigid body. However, after #809, this does not work properly, and you should instead use theSleepBodyandWakeBodycommands.Additionally,
SleepBodydoes not currently split the island, which can cause bodies that are not in contact to also be forced asleep.Solution
Split islands when using
SleepBody, and add hooks to automatically sleep/wake bodies whenSleepingis manually added/removed.