Conversation
28 tasks
fix "temporaries freed while still in use" across a couple of function uses. ## Solution I took the approach of keeping the clones of things like `DebugName` from the `.name` function, etc and instead stored the value so it could be referenced, since the usage relies on deref coercion to go from `DebugName` to `&str`. The examples run after this fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Update Avian to Bevy 0.17!
Solution
CollisionStarted,CollisionEnded,OnCollisionStart, andOnCollisionEndintoCollisionStartandCollisionEndeventsMessageand triggered as anEventFooSetto the newFooSystemsconventionBvhinstead of the oldQbvhMigration Guide
Collision Events
The
CollisionStarted,CollisionEnded,OnCollisionStart, andOnCollisionEndevents have been replaced by theCollisionStartandCollisionEndevents. They are both written as aMessageand triggered as anEvent, and store the collider and body entity of both colliders involved in the event.A collision event observer before:
and after:
A collision event reader system before:
and after:
System Sets
System sets have been renamed to follow the new
FooSystemsnaming convention.PhysicsSet→PhysicsSystemsPhysicsStepSet→PhysicsStepSystemsSubstepSet→SubstepSystemsSubstepSolverSet→SubstepSolverSystemsSolverSet→SolverSystemsIntegrationSet→IntegrationSystemsBroadPhaseSet→BroadPhaseSystemsNarrowPhaseSet→NarrowPhaseSystemsSweptCcdSet→SweptCcdSystemsPhysicsTransformSet→PhysicsTransformSystemsColliderConstructorHierarchyBevy 0.17 changed the way
Nameworks for glTF mesh primitives (migration guide). Instead ofMeshName.PrimitiveIndex, it is now in the form ofMeshName.MaterialName. This also means that APIs such asColliderConstructorHierarchy::with_constructor_for_namenow use this format.