Rename entity properties in ContactPair and ContactConstraint#719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Follow-up to #718.
ContactPairhasentity1,entity2,body_entity1, andbody_entity2, whileContactConstrainthasentity1,entity2,collider_entity1, andcollider_entity2. Theentityspecifiers are kind of unnecessary, and it'd be nice if the names were more consistent andentity1andentity2were more explicit about whether they are the collider or body entities.Solution
Rename the properties such that both
ContactPairandContactConstrainthavecollider1,collider2,body1, andbody2.Migration Guide
ContactPair: Theentity1andentity2properties are nowcollider1andcollider2, andbody_entity1andbody_entity2are nowbody1andbody2.ContactConstraint: Theentity1andentity2properties are nowbody1andbody2, andcollider_entity1andcollider_entity2are nowcollider1andcollider2.