Clean up collision detection module structure and re-exports#698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Some of the collision detection modules are not located in the most appropriate place, and the imports are a bit messy.
Solution
Move
layersfromcollisiontocollision::collidercontact_queryfromcollisiontocollision::collider::parryfeature_idfromcollisiontocollision::contact_typesI also removed the
collider::*andlayers::*re-exports from thecollisionmodule, and instead added apreludefor collision detection functionality.Migration Guide
Some collision detection modules and imports have been reorganized.
The following modules have been moved:
layersfromcollisiontocollision::collidercontact_queryfromcollisiontocollision::collider::parryfeature_idfromcollisiontocollision::contact_typesPreviously, a lot of collision detection types were also re-exported directly from the
collisionmodule. Now, there is instead apreludefor thecollisionmodule.