Fix contact pair removal bugs#693
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Contact pair removal currently has some issues.
EdgeIndexdirectly, but removing an edge can move the indices around (due toswap_remove), which can sometimes result in incorrect pair removal if many pairs are removed at once.CollisionLayersdoesn't update existing contact pairs.CollisionEndedis sent even for non-touching contact pairs.Solution
Fix the things!
For problem 2, I just made the narrow phase always check if the
CollisionLayersmatch for now. Ideally, we'd handle this with fine-grained change detection instead.CollisionLayersis now also a required component for colliders. This avoids extra branching and is perhaps more semantically accurate; colliders can only belong to collision layers if they have the component for it.Migration Guide
CollisionLayersis now a required component for colliders.