Use required components for component initialization#541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Bevy 0.15 got support for required components! We can replace a lot of our custom-made automatic component insertion with them, reducing the number of archetype moves and making startup more efficient.
Solution
Use required components for most component initialization logic.
I have also made
CollidingEntitiesoptional, as adding it automatically for every collider wastes memory unnecessarily. It must now be added manually.Follow-ups
PositionandRotationrequired and reworkinit_transforms(ran into some ordering issues, so left it to a follow-up)Migration Guide
The
CollidingEntitiescomponent is no longer added automatically. To read entities that are colliding with a given entity, you must now add theCollidingEntitiescomponent for it manually.To revert to the old behavior, you can also make
CollidingEntitiesa required component for colliders: