Use hooks for component initialization#483
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #475.
Missing components for rigid bodies, colliders, etc. are currently added at specific points in the physics shedule. This means that the world is momentarily in an invalid state before those systems are run, which can even lead to confusing crashes when using methods like
query.single()for queries that expect those components to exist.Solution
Use component hooks for initializing missing components with minimal delay. This also meaningfully simplifies scheduling.
When Bevy gets required components (Soon™), those could be used instead.
Performance
Using hooks appears to be as fast if not faster than the old initialization systems.
Migration Guide
PrepareSet::PreInithas been renamed toPrepareSet::First, andPrepareSet::InitRigidBodies,PrepareSet::InitColliders, andPrepareSet::InitMassPropertieshave been removed. Most missing components are now initialized by component lifecycle hooks.CcdPluginandSpatialQueryPipelineno longer store a schedule and are now unit structs. Instead ofSpatialQueryPlugin::new(my_schedule)orSpatialQueryPlugin::default(), just useSpatialQueryPlugin.