Take SpatialQueryFilter by reference in spatial queries#402
Merged
Conversation
janhohenheim
approved these changes
Jul 6, 2024
janhohenheim
left a comment
Member
There was a problem hiding this comment.
Oh nice, you managed to make all of the spatial queries take the filter by reference!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Spatial queries currently take
SpatialQueryFilterby value and clone it several times. This could sometimes be cloning a pretty hefty amount of data if theHashSetof excluded entities is large.Solution
Take spatial query filters by reference and reduce the amount of cloning.
Future Work
Shapecasting with multiple hits should be optimized to only traverse once instead of doing best-first traversals in a loop. See #403.
Migration Guide
Spatial queries performed through
SpatialQuerynow takeSpatialQueryFilterby reference.