Allow using forbidden clauses with non-numeric values#230
Allow using forbidden clauses with non-numeric values#230mfeurer merged 2 commits intoautoml:masterfrom
Conversation
Both of these tests currently raise an exception: > TypeError: must be real number, not str
This commit solves the two failing tests.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 67.11% 67.11%
=======================================
Files 17 17
Lines 1627 1627
=======================================
Hits 1092 1092
Misses 535 535 Continue to review full report at Codecov.
|
|
Thanks for catching this. I can reproduce the issue and am currently checking your proposed fix. It looks good. I have one question, though: it appears that PS: Your other PR is next on my list. |
|
I implemented a procedure that samples configuration according to a dynamic probability distribution. This procedure calls |
|
Got it, thanks for the explanation. I could find no performance decrease when benchmarking the sampling speed, so let's merge this :) |
Before
Restricting a categorical hyperparameter with non-numeric (namely string) values by a forbidden clause
forbiddenand callingforbidden.is_forbiddenon a relevantinstantiated_hyperparametersdictionary raises the following exception:After
Forbidden clauses that involve non-numeric hyperparameters can be evaluated using
is_forbiddenwithout raising an exception.