add github copilot models to factory setup guide#252
add github copilot models to factory setup guide#252ranaroussi merged 1 commit intoautomazeio:mainfrom
Conversation
📝 WalkthroughWalkthroughFACTORY_SETUP.md documentation updated to integrate GitHub Copilot support. Changes include: adding Copilot as an optional prerequisite, updating setup flow to connect GitHub Copilot instead of Z.AI GLM account, expanding Factory configuration with Copilot-based models, and introducing a GitHub Copilot Models documentation section. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
FACTORY_SETUP.md (1)
358-360: Expand Step 4 examples to include all newly added Copilot models.Line 358 lists only
claude-opus-4.6, while this PR adds multiple Copilot models. Includingclaude-sonnet-4.6,claude-haiku-4.5,gpt-5.3-codex, andgemini-3-pro-previewhere would improve discoverability.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@FACTORY_SETUP.md` around lines 358 - 360, Update the Step 4 example list that currently only shows `claude-opus-4.6` to include the newly added Copilot models: add `claude-sonnet-4.6`, `claude-haiku-4.5`, and `gpt-5.3-codex`, and ensure `gemini-3-pro-preview` is present in the examples alongside `gpt-5.1`/`gpt-5.1-codex`; edit the bullet list in FACTORY_SETUP.md (the section with the models examples) to include these model names so they are discoverable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@FACTORY_SETUP.md`:
- Around line 184-186: The duplicated model ID "gemini-3-pro-preview" is defined
for two providers (Copilot and Antigravity) which prevents routing by model-id;
update one of the entries to use a provider-specific model id (for example
change "model": "gemini-3-pro-preview" to "model":
"gemini-3-pro-preview-copilot" or "...-antigravity") in the FACTORY_SETUP.md
entries referencing the Copilot/Antigravity configs (search for
"model_display_name": "GH: Gemini 3 Pro (via Copilot)" and the Antigravity
block) and/or add a short note explaining the disambiguation strategy so
backend/quota selection can deterministically pick provider-specific backends.
---
Nitpick comments:
In `@FACTORY_SETUP.md`:
- Around line 358-360: Update the Step 4 example list that currently only shows
`claude-opus-4.6` to include the newly added Copilot models: add
`claude-sonnet-4.6`, `claude-haiku-4.5`, and `gpt-5.3-codex`, and ensure
`gemini-3-pro-preview` is present in the examples alongside
`gpt-5.1`/`gpt-5.1-codex`; edit the bullet list in FACTORY_SETUP.md (the section
with the models examples) to include these model names so they are discoverable.
| "model_display_name": "GH: Gemini 3 Pro (via Copilot)", | ||
| "model": "gemini-3-pro-preview", | ||
| "base_url": "http://localhost:8317/v1", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# First, verify duplicate model IDs exist in FACTORY_SETUP.md
python3 - <<'PY'
import re
from collections import Counter
text = open("FACTORY_SETUP.md", encoding="utf-8").read()
models = re.findall(r'"model"\s*:\s*"([^"]+)"', text)
dups = [m for m,c in Counter(models).items() if c > 1]
print("=== All model IDs found ===")
for m, c in Counter(models).most_common():
if c > 1:
print(f"{m}: {c} times")
print("\n=== Line numbers for gemini-3-pro-preview ===")
for i, line in enumerate(text.split('\n'), 1):
if '"gemini-3-pro-preview"' in line:
print(f"Line {i}: {line.strip()}")
PYRepository: automazeio/vibeproxy
Length of output: 254
🏁 Script executed:
# Also check context around the claimed line 185 (Copilot) and line 263 (Antigravity)
head -n 190 FACTORY_SETUP.md | tail -n 20Repository: automazeio/vibeproxy
Length of output: 652
🏁 Script executed:
# Check context around line 263
sed -n '255,275p' FACTORY_SETUP.mdRepository: automazeio/vibeproxy
Length of output: 696
Resolve duplicate gemini-3-pro-preview model ID across authentication providers.
The model ID gemini-3-pro-preview appears on both line 185 (Copilot) and line 263 (Antigravity). If backend/quota selection is model-id based, users cannot intentionally route requests to Copilot vs. Antigravity quota. Either rename one model ID to be provider-specific (e.g., gemini-3-pro-preview-copilot) or document how the system disambiguates when the same model ID exists under multiple auth contexts.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@FACTORY_SETUP.md` around lines 184 - 186, The duplicated model ID
"gemini-3-pro-preview" is defined for two providers (Copilot and Antigravity)
which prevents routing by model-id; update one of the entries to use a
provider-specific model id (for example change "model": "gemini-3-pro-preview"
to "model": "gemini-3-pro-preview-copilot" or "...-antigravity") in the
FACTORY_SETUP.md entries referencing the Copilot/Antigravity configs (search for
"model_display_name": "GH: Gemini 3 Pro (via Copilot)" and the Antigravity
block) and/or add a short note explaining the disambiguation strategy so
backend/quota selection can deterministically pick provider-specific backends.
There was a problem hiding this comment.
yeah bro, but it is expected
There was a problem hiding this comment.
@yigitkonur, got it! Thanks for clarifying that the duplicate model IDs are intentional. I appreciate you letting me know how the system is designed to handle this.
🐰✨
✏️ Learnings added
Learnt from: yigitkonur
Repo: automazeio/vibeproxy PR: 252
File: FACTORY_SETUP.md:184-186
Timestamp: 2026-02-27T11:40:53.143Z
Learning: In VibeProxy's FACTORY_SETUP.md configuration, duplicate model IDs across different authentication providers (e.g., `gemini-3-pro-preview` appearing for both Copilot and Antigravity providers) are expected behavior and should not be flagged as issues.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
adds copilot section to factory_setup.md — connection steps, config entries, and model list for the 5 main copilot models (opus 4.6, sonnet 4.6, haiku 4.5, gpt-5.3-codex, gemini 3 pro). also mentions how to discover new model names via
copilot --help. small addition but useful for droid users who have a copilot sub.Summary by CodeRabbit
Documentation