Skip to content

Add option to disable ejection on an unidentified disc (#779)#937

Merged
shitwolfymakes merged 2 commits intoautomatic-ripping-machine:mainfrom
martini1992:main
Sep 24, 2023
Merged

Add option to disable ejection on an unidentified disc (#779)#937
shitwolfymakes merged 2 commits intoautomatic-ripping-machine:mainfrom
martini1992:main

Conversation

@martini1992
Copy link
Copy Markdown

@martini1992 martini1992 commented Sep 10, 2023

Description

Disables the automatic ejecting of an unidentified disc, to prevent immediate ejection of discs on certain (Pioneer slim) drives.

Fixes #779

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    (Could be seen as both)

How Has This Been Tested?

Several people on the ticket including me have tested removing the offending line (including me).
I have added extra code to make this configurable, with the default behaviour being the original behaviour.

  • Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

@martini1992 martini1992 changed the title Add option to disable ejection on an unidentified disc (#799) Add option to disable ejection on an unidentified disc (#779) Sep 10, 2023
@1337-server 1337-server added the Bugfix Bugfixes in PR label Sep 11, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shitwolfymakes shitwolfymakes merged commit 9064600 into automatic-ripping-machine:main Sep 24, 2023
truecharts-admin referenced this pull request in trueforge-org/truecharts Jan 3, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (#16800)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.60` -> `2.6.67` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67)

#### What's Changed

- Fix for 914 - automatic build/release creating new release everytime
by [@&#8203;1337-server](https://togithub.com/1337-server) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/917](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/917)
- Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/920](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/920)
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/932](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/932)
- Ntfy and Bash for notifications by
[@&#8203;newhinton](https://togithub.com/newhinton) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/930](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/930)
- Fix handling of the abcde.conf file for docker by
[@&#8203;martini1992](https://togithub.com/martini1992) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/938](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/938)
- Add option to disable ejection on an unidentified disc
([#&#8203;779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779))
by [@&#8203;martini1992](https://togithub.com/martini1992) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/937](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/937)
- Bump docker/build-push-action from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/940](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/940)
- Bump docker/metadata-action from 4.6.0 to 5.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/943](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/943)
- Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/941](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/941)
- Bump docker/login-action from 2.2.0 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/942](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/942)
- Add k10temp support for more AMD platforms by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/958](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/958)
- Fix transcode free space by
[@&#8203;rgooler](https://togithub.com/rgooler) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/954](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/954)
- Add Apprise test button by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/963](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/963)
- Resolved issue with dev tools by
[@&#8203;microtechno9000](https://togithub.com/microtechno9000) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/966](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/966)
- Use Waitress as WSGI Server by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/964](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/964)
- Bump arm-dependencies from `0d608cb` to `c3b0745` by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/970](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/970)
- Parse bluray label for OMDB search by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/962](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/962)
- Models Refactor by
[@&#8203;shitwolfymakes](https://togithub.com/shitwolfymakes) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/977](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/977)

#### New Contributors

- [@&#8203;martini1992](https://togithub.com/martini1992) made their
first contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/938](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/938)
- [@&#8203;anthonylavado](https://togithub.com/anthonylavado) made their
first contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/958](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/958)
- [@&#8203;rgooler](https://togithub.com/rgooler) made their first
contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/954](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/954)

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
GabrielBarzen referenced this pull request in GabrielBarzen/charts Feb 2, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (trueforge-org#16800)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.60` -> `2.6.67` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67)

#### What's Changed

- Fix for 914 - automatic build/release creating new release everytime
by [@&trueforge-org#8203;1337-server](https://togithub.com/1337-server) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/917](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/917)
- Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/920](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/920)
- Bump actions/checkout from 3 to 4 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/932](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/932)
- Ntfy and Bash for notifications by
[@&trueforge-org#8203;newhinton](https://togithub.com/newhinton) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/930](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/930)
- Fix handling of the abcde.conf file for docker by
[@&trueforge-org#8203;martini1992](https://togithub.com/martini1992) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/938](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/938)
- Add option to disable ejection on an unidentified disc
([#&trueforge-org#8203;779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779))
by [@&trueforge-org#8203;martini1992](https://togithub.com/martini1992) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/937](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/937)
- Bump docker/build-push-action from 4 to 5 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/940](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/940)
- Bump docker/metadata-action from 4.6.0 to 5.0.0 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/943](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/943)
- Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/941](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/941)
- Bump docker/login-action from 2.2.0 to 3.0.0 by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/942](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/942)
- Add k10temp support for more AMD platforms by
[@&trueforge-org#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/958](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/958)
- Fix transcode free space by
[@&trueforge-org#8203;rgooler](https://togithub.com/rgooler) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/954](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/954)
- Add Apprise test button by
[@&trueforge-org#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/963](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/963)
- Resolved issue with dev tools by
[@&trueforge-org#8203;microtechno9000](https://togithub.com/microtechno9000) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/966](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/966)
- Use Waitress as WSGI Server by
[@&trueforge-org#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/964](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/964)
- Bump arm-dependencies from `0d608cb` to `c3b0745` by
[@&trueforge-org#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/970](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/970)
- Parse bluray label for OMDB search by
[@&trueforge-org#8203;anthonylavado](https://togithub.com/anthonylavado) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/962](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/962)
- Models Refactor by
[@&trueforge-org#8203;shitwolfymakes](https://togithub.com/shitwolfymakes) in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/977](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/977)

#### New Contributors

- [@&trueforge-org#8203;martini1992](https://togithub.com/martini1992) made their
first contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/938](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/938)
- [@&trueforge-org#8203;anthonylavado](https://togithub.com/anthonylavado) made their
first contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/958](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/958)
- [@&trueforge-org#8203;rgooler](https://togithub.com/rgooler) made their first
contribution in
[https://github.com/automatic-ripping-machine/automatic-ripping-machine/pull/954](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/pull/954)

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Bugfixes in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Blue Ray Drive ejects Disk immediately and Drive blinks rapidly

3 participants