[BUGFIX] Gracefull shutdown of armui service outside docker#1730
Merged
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom Apr 2, 2026
Merged
Conversation
Resolves issue when running not in docker
Properly handle file checks, removing resource leak, closing file once read.
|
7c03458
into
automatic-ripping-machine:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Resolves system hanging issues #1705 when running outside docker. Systemd will call ARM with sigterm and shutdown gracefully.
Also removed resource leak when checking if running within docker.
Amended debian start script to use the same armui.service file, removed duplicate arm.service file
Fixes #1705
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist:
Changelog:
Include the details of changes made here
Logs
Nil impact on ripping