Skip to content

[BUGFIX] Gracefull shutdown of armui service outside docker#1730

Merged
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
microtechno9000:bugfix_armui_service
Apr 2, 2026
Merged

[BUGFIX] Gracefull shutdown of armui service outside docker#1730
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
microtechno9000:bugfix_armui_service

Conversation

@microtechno9000
Copy link
Copy Markdown
Collaborator

Description

Resolves system hanging issues #1705 when running outside docker. Systemd will call ARM with sigterm and shutdown gracefully.

Also removed resource leak when checking if running within docker.

Amended debian start script to use the same armui.service file, removed duplicate arm.service file

Fixes #1705

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Docker
  • Other (Please state here)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

  • Amended armui.service to handle gracefull shutdown
  • Removed duplicate file arm.service
  • Amended runui.py to handle signal (SIGINT and SIGTERM)

Logs

Nil impact on ripping

microtechno9000 and others added 3 commits March 13, 2026 09:59
Resolves issue when running not in docker
Properly handle file checks, removing resource leak, closing file once read.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 2, 2026

@microtechno9000 microtechno9000 merged commit 7c03458 into automatic-ripping-machine:main Apr 2, 2026
11 checks passed
@microtechno9000 microtechno9000 deleted the bugfix_armui_service branch April 2, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SYSTEMD Control File Missing Line

1 participant