[BUGFIX] Gracefully handle read-only config files#1694
Merged
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom Mar 12, 2026
Merged
[BUGFIX] Gracefully handle read-only config files#1694microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
Conversation
Open
ARM no longer crashes when any config file is read-only, if that is the case, the respective settings page fields are grayed out and offer a tooltip detailing why.
microtechno9000
approved these changes
Mar 12, 2026
Collaborator
microtechno9000
left a comment
There was a problem hiding this comment.
nice addition and check for corner cases, or users operating with nixos
|
5b786e2
into
automatic-ripping-machine:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Under NixOS, config files are almost always read-only, since they are generated by the OS and are supposed to be reproducible and thus immutable. As of right now, ARM refuses to start if
arm.yamlis read-only. This PR seeks to address that.Changes
ARM no longer crashes when any config file is read-only, if that is the case, the respective settings page fields are grayed out and offer a tooltip detailing why.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
chmod a-w config/*Successfully started ARM and visited the settings page, observed that it looked as intended.
chmod ug+w config/*Visited the settings page and confirmed that modifying and saving the files still worked as intended.
Checklist: