Skip to content

[BUGFIX] use Python instead of tail#1693

Merged
microtechno9000 merged 1 commit intoautomatic-ripping-machine:mainfrom
xieve:fix-python-less
Mar 10, 2026
Merged

[BUGFIX] use Python instead of tail#1693
microtechno9000 merged 1 commit intoautomatic-ripping-machine:mainfrom
xieve:fix-python-less

Conversation

@xieve
Copy link
Copy Markdown
Contributor

@xieve xieve commented Feb 6, 2026

Description

tail exhibits significant performance issues on files above the ~20MiB range, which is reached quite easily on the DEBUG loglevel, because of the makemkv messaging. This PR replaces the call to tail with a very simple native implementation, which is orders of magnitude faster.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ripped a disc, used the "tail" option on the logs.

  • Docker
  • Other (My own NixOS module)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Logs

DVDVIDEO_177039962042.log

`tail` exhibits significant performance issues on files above the ~20MiB range, which is reached quite easily on the DEBUG loglevel, because of the makemkv messaging. This PR replaces the call to `tail` with a very simple native implementation, which is orders of magnitude faster.
@xieve xieve force-pushed the fix-python-less branch from d438d83 to 8638a22 Compare March 1, 2026 08:54
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 1, 2026

@microtechno9000 microtechno9000 merged commit 53bdf79 into automatic-ripping-machine:main Mar 10, 2026
11 of 12 checks passed
@xieve xieve deleted the fix-python-less branch March 12, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants