[BUGFIX] use Python instead of tail#1693
Merged
microtechno9000 merged 1 commit intoautomatic-ripping-machine:mainfrom Mar 10, 2026
Merged
[BUGFIX] use Python instead of tail#1693microtechno9000 merged 1 commit intoautomatic-ripping-machine:mainfrom
tail#1693microtechno9000 merged 1 commit intoautomatic-ripping-machine:mainfrom
Conversation
`tail` exhibits significant performance issues on files above the ~20MiB range, which is reached quite easily on the DEBUG loglevel, because of the makemkv messaging. This PR replaces the call to `tail` with a very simple native implementation, which is orders of magnitude faster.
|
microtechno9000
approved these changes
Mar 10, 2026
53bdf79
into
automatic-ripping-machine:main
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
tailexhibits significant performance issues on files above the ~20MiB range, which is reached quite easily on the DEBUG loglevel, because of the makemkv messaging. This PR replaces the call totailwith a very simple native implementation, which is orders of magnitude faster.Type of change
How Has This Been Tested?
Ripped a disc, used the "tail" option on the logs.
Checklist:
Logs
DVDVIDEO_177039962042.log