Skip to content

[BUGFIX] resolve x86 CPU Model Name Bug#1647

Merged
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
GalFawkes:main
Jan 20, 2026
Merged

[BUGFIX] resolve x86 CPU Model Name Bug#1647
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom
GalFawkes:main

Conversation

@GalFawkes
Copy link
Copy Markdown
Contributor

@GalFawkes GalFawkes commented Dec 16, 2025 •
edited
Loading

re.IGNORECASE causes a hit on the CPU model number before the CPU name (this has been edited per my most recent comment on this PR). On a 6th-gen x86 Intel CPU, the CPU ID is 94, not a CPU model string.

Description

I would like to update arm/models/system_info.py to fix a regex issue when ARM is running in Docker on x86 CPUs. Currently, the model number is displayed instead of the CPU name (not expected behavior).

Context: I was wondering why the CPU was listed as 94 instead of as a 6th gen i5.
Motivation: I realized it was a bug.

Fixes #1646 (admittedly, I also created this issue a bit ago.)

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I used a python shell with the relevant cpuinfo data dumped to a text file as well as a few different regex calculators online. As this is a relatively minor change, I didn't redeploy arm to validate. I am using Docker on Debian Trixie.

  • [ x ] Docker

Checklist:

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

  • Removed re.IGNORECASE from regex in line 47 of arm/models/system_info.py

Logs

N/A, minor bugfix

@GalFawkes
[BUGFIX] resolve x86 CPU Model Name Bug
4aaedc6 
`re.IGNORECASE` also somehow ignores spaces. I'm not sure why, but on an x86 Intel CPU, the CPU ID is 94, not a CPU model string.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GalFawkes
Copy link
Copy Markdown
Contributor Author

GalFawkes commented Dec 17, 2025 •
edited
Loading

Update to "regex ignores spaces":

It doesn't, it just matched "Model" case insensitively, meaning I got ths "model", not the "model name" of my CPU.

Whoops! Error and fix is still valid as far as I can tell 😅

microtechno9000
microtechno9000 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@microtechno9000 microtechno9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed works

microtechno9000
microtechno9000 requested changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@microtechno9000 microtechno9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version bump required

microtechno9000
microtechno9000 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@microtechno9000 microtechno9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed works, version bump added

@microtechno9000
Copy link
Copy Markdown
Collaborator

microtechno9000 commented Jan 20, 2026

Thanks for updating and fixing this.
For future, can you add something like the below showing the output from the docker container showing the correct information, with debug turned on.

Confirmed tested locally and CPU information now correct

[2026-01-20 12:47:49,406] DEBUG ARM: notifications.arm_nav_notify 1
[2026-01-20 12:47:54,875] DEBUG ARM: system_info.get_cpu_info ****** Getting CPU Info ******
[2026-01-20 12:47:54,878] DEBUG ARM: system_info.get_cpu_info Regex output: <re.Match object; span=(67, 126), match='model name\t: 11th Gen Intel(R) Core(TM) i5-1135G>
[2026-01-20 12:47:54,878] DEBUG ARM: system_info.get_cpu_info CPU Info: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
[2026-01-20 12:47:54,878] DEBUG ARM: system_info.get_cpu_info ****************************
[2026-01-20 12:47:54,878] DEBUG ARM: settings.update_sysinfo ****** System Information ******
[2026-01-20 12:47:54,879] DEBUG ARM: settings.update_sysinfo Name old [ARM Server] new [ARM Server]
[2026-01-20 12:47:54,879] DEBUG ARM: settings.update_sysinfo Name old [140] new [11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz]
[2026-01-20 12:47:54,879] DEBUG ARM: settings.update_sysinfo Name old [7.5] new [7.5]
[2026-01-20 12:47:54,879] DEBUG ARM: settings.update_sysinfo ****** End System Information ******

@microtechno9000 microtechno9000 merged commit 8216843 into automatic-ripping-machine:main Jan 20, 2026
8 checks passed
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GalFawkes
Copy link
Copy Markdown
Contributor Author

GalFawkes commented Jan 20, 2026

Absolutely, thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@microtechno9000 microtechno9000 microtechno9000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CPU Names are Not Displayed for x86 Processors

2 participants

@GalFawkes @microtechno9000