Do not cache splits as attributes of the EvaluationWindow
#86
+46
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Problem: When calling
task.evaluation_summary(), newEvaluationWindowobjects are created for each window. Each window then calls_prepare_dataset_dict()which loads and splits all data from scratch. This is a bigger problem now since all datasets are stored in memory.Solution:
_dataset_dictcaching fromEvaluationWindowreturn_pastandreturn_futureflags topast_future_split()to skip unnecessary slicingget_ground_truth()now only processes[id, timestamp, target]columns withreturn_past=False, avoiding slicing of past data entirelyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.