fix(cookie): make HttpOnly unconditional on all cookies [C4]#546
Merged
lakhansamani merged 1 commit intomainfrom Apr 4, 2026
Merged
fix(cookie): make HttpOnly unconditional on all cookies [C4]#546lakhansamani merged 1 commit intomainfrom
lakhansamani merged 1 commit intomainfrom
Conversation
HttpOnly was tied to the Secure flag, meaning cookies were accessible to JavaScript when running without TLS. This enabled trivial XSS-based session theft. HttpOnly is now always true regardless of Secure setting. Affected: session cookies, admin cookies, MFA session cookies. Fixes: C4 (Critical)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/cookie/cookie.go: httpOnly = true (was appCookieSecure)internal/cookie/admin_cookie.go: httpOnly = true (was adminCookieSecure)internal/cookie/mfa_session.go: httpOnly = true (was appCookieSecure)Test plan