fix(crypto): switch AES-CFB to AES-GCM with HKDF key derivation [C1+H3]#543
Merged
lakhansamani merged 1 commit intomainfrom Apr 3, 2026
Merged
fix(crypto): switch AES-CFB to AES-GCM with HKDF key derivation [C1+H3]#543lakhansamani merged 1 commit intomainfrom
lakhansamani merged 1 commit intomainfrom
Conversation
AES-CFB provides no integrity/authentication, allowing attackers to bit-flip encrypted session tokens to alter user ID or roles without detection. AES-GCM provides authenticated encryption. Also replaces null-byte key padding with HKDF-SHA256 key derivation, ensuring full entropy utilization regardless of input key length. Fixes: C1 (Critical), H3 (High)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/crypto/aes.go: Complete rewrite of EncryptAES/DecryptAES using AES-256-GCM + HKDFinternal/crypto/aes_test.go: New test suite covering roundtrip, tamper detection, wrong key, short/long keysSecurity Impact
Test plan