fix: prevent OAuth account pre-hijacking via unverified email linking#503
Merged
lakhansamani merged 1 commit intomainfrom Mar 30, 2026
Merged
fix: prevent OAuth account pre-hijacking via unverified email linking#503lakhansamani merged 1 commit intomainfrom
lakhansamani merged 1 commit intomainfrom
Conversation
When an OAuth login matches an existing account by email, the handler now checks EmailVerifiedAt. If the existing account's email was never verified, the unverified account is deleted and a fresh one is created for the OAuth user. This prevents attackers from pre-registering with a victim's email to retain password access after the victim's OAuth login.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attack scenario (before fix)
victim@company.com+ password, does NOT verify emailTest plan
TestOAuthAccountLinkingPreHijack/unverified_account_should_not_retain_password_after_oauth_signupTestOAuthAccountLinkingPreHijack/verified_account_should_link_oauth_identityTestOAuthAccountLinkingPreHijack/attacker_cannot_login_after_victim_oauthTestOAuthAccountLinkingPreHijack/revoked_unverified_account_should_block_oauthTestOAuthAccountLinkingPreHijack/multiple_oauth_providers_link_to_verified_accountTestOAuthAccountLinkingPreHijack/unverified_account_deletion_is_clean