fix(win): fix plugin startup / use FileAppender#45
Conversation
|
Tested this out x-plat, in dotnet & pact-go. fixes the startup issues. Shutdown issues on windows resolved by pact-foundation/pact-plugins#69 specifically this line https://github.com/pact-foundation/pact-plugins/pull/69/files#diff-0d68f182064e209fefba06eec9ce538b69dc667ef8fcba52143b0778cdb7b3ebR122 If they update to the latest version of the pact-avro-plugin that includes this release, it will work with the current FFI, and later versions of the FFI, consuming the above pact-plugin change. So don't delay, update today 😅 |
| <file>logs/plugin.log</file> | ||
| <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> | ||
| <!-- daily rollover --> | ||
| <!-- <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy"> |
There was a problem hiding this comment.
as the RollingFileAppender is not used anymore, there is no need to keep the settings for it
issues on reading the plugin startup message when using system threads over tokio tasks, seem to be due to the RollingFileAppender
2516e3e to
aee1662
Compare
issues on reading the plugin startup message when using system threads over tokio tasks, seem to be due to the RollingFileAppender
Built locally on a mac m1 (via docker) and tested in a windows VM using parallels
Plugin now start ups correctly, and maintains logs. fixes #42
Using the pact-plugin-driver with this change
https://github.com/pact-foundation/pact-plugins/pull/69/files#diff-e21b8ae9cb59f07bada083f39629f6fbc221a1c6ca0ad395799d0bad5f7bc941R290
in order to terminate child processes on windows, will fix the shut down issues.
Tested e2e with the avro plugin example in https://github.com/pact-foundation/pact-go/tree/master/examples/avro