Skip to content

Add test client package#360

Merged
chiphogg merged 3 commits intomainfrom
chiphogg/cmake-client-ci#359
Dec 16, 2024
Merged

Add test client package#360
chiphogg merged 3 commits intomainfrom
chiphogg/cmake-client-ci#359

Conversation

@chiphogg
Copy link
Copy Markdown
Member

@chiphogg chiphogg commented Dec 15, 2024

This makes sure that clients can use a version of Au that is installed
by CMake.

First, we add the new workflow, to make sure that it breaks in exactly
the way that reveals #359. Then, in a new commit in this same PR, we
will fix the bug.

Fixes #359.

This makes sure that clients can use a version of Au that is installed
by CMake.

Fixes #359.
@chiphogg chiphogg added release notes: 🐛 lib (bugfix) PR fixing a defect in the library code release notes: ⚙️ repo PR affecting the way the repository works labels Dec 15, 2024
@chiphogg chiphogg requested a review from timhirsh December 15, 2024 20:32
@chiphogg chiphogg marked this pull request as ready for review December 15, 2024 20:33
@chiphogg chiphogg requested a review from a team as a code owner December 15, 2024 20:33
quantity.hh
quantity_point.hh
rep.hh
static_cast_checkers.hh
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are the ones that fix the actual bug.

Copy link
Copy Markdown
Member

@timhirsh timhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chiphogg chiphogg merged commit d8cf816 into main Dec 16, 2024
@chiphogg chiphogg deleted the chiphogg/cmake-client-ci#359 branch August 17, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: 🐛 lib (bugfix) PR fixing a defect in the library code release notes: ⚙️ repo PR affecting the way the repository works

Projects

None yet

Development

Successfully merging this pull request may close these issues.

au/static_cast_checkers.hh missing from CMakeLists.txt

2 participants