This repository was archived by the owner on May 29, 2020. It is now read-only.
Specific messages for delayed or disabled cron events#58
Merged
pbiron merged 2 commits intoaudrasjb:masterfrom Mar 16, 2020
Merged
Specific messages for delayed or disabled cron events#58pbiron merged 2 commits intoaudrasjb:masterfrom
pbiron merged 2 commits intoaudrasjb:masterfrom
Conversation
…for plugins and updates pages
Collaborator
|
thanx @bookdude13 I'll look this over shortly. |
pbiron
suggested changes
Mar 16, 2020
Collaborator
pbiron
left a comment
There was a problem hiding this comment.
Seems to work as I expect it to, both on the plugins.php and update-core.php screens under all conditions (cron job not scheduled, cron disabled, scheduled update overdue and scheduled update in the future).
Can you make a couple of minor changes:
- the 1st 2 strings (for cron not scheduled/disabled) need the
wp-autoupdatesdomain added. - change
CrontoWP-Cronin the text of the 2nd string, for consistency with the other strings that mention cron. - move the new
wp_autoupdates_get_update_message()function to the end of the file rather than having it at the beginning.
Contributor
Author
|
Can do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
This also standardizes the messages between the Updates and the Plugins pages. Specific messages for when cron is disabled, the event is delayed, and when the event is scheduled in the future.
Note that the messages are displayed directly in the column. If they should instead be shown in the banner like other errors, or use the messaging like @afragen mentioned in #55 let me know and I can update.