Remove update time text after manual update#43
Conversation
wp-autoupdates.php
Outdated
| Author: The WordPress Team | ||
| Author URI: https://wordpress.org | ||
| Contributors: wordpressdotorg, audrasjb, whodunitagency, pbiron, xkon, karmatosed, mapk | ||
| Contributors: wordpressdotorg, audrasjb, whodunitagency, pbiron, xkon, karmatosed, mapk, bookdude13 |
There was a problem hiding this comment.
Please don’t directly add your name to the contributors on the plugin header.
You can add your name on the readme.md file and I will take care your name is added to the props list of WordPress 5.5, but the plugin’s list of contributors is updated manually.
Thanks for your comprehension :)
There was a problem hiding this comment.
My bad, and understood :) I thought I saw something similar in a PR here, but must've been mistaken.
pbiron
left a comment
There was a problem hiding this comment.
The </span> should be output before the <br />.
pbiron
left a comment
There was a problem hiding this comment.
Setting the text to the empty string works. but I think it would be better to just remove the span (e.g., plugin_auto_update_time_text.remove().
Dismissing review as per @pbiron’s comment
I agree, removed.
If this happens then there is a gap between the auto-updates enabled text and the enable/disable link (see Hello Dolly): I could try to use other selectors to remove that |
You're right, my bad...I reviewed too quickly. @audrasjb I think this is good to go now. |
|
Yeah, it's good to go. Thank you @bookdude13 👍 |
Fixes #28.
Note that in #28 the issue disappeared after a refresh, since the page reloading set the text properly. I didn't think a page reload made sense after an update (especially since multiple updates may occur with bulk actions), so I added a jQuery hook. If there are coding standard changes, or a better place to put this, let me know and I can update it. I'm always ready to learn 😄