This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Clarify deprecation of undo: skip option#295
Merged
jasonrudolph merged 2 commits intomasterfrom Apr 9, 2018
Merged
Conversation
Contributor
Author
|
To verify that the deprecation warning is wired up correctly, I ran Atom in dev mode and executed the following code in the console: atom.workspace.getActiveTextEditor().getBuffer().setTextInRange([[0,0], [0,1]], 'foo', {undo: 'skip'})Afterwards, Atom correctly reports the use of this deprecated option:
|
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#282 updated the docs for
TextBuffer::setTextInRangeto deprecate theundooption. atom/atom#16956 points out that there are other public methods whose docs reference theundooption. This pull request updates the docs for those other methods so that they also identify theundooption as deprecated. It also emits a deprecation warning whenever theundooption is used.