This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Exclude package-lock.json from repo#125
Merged
jasonrudolph merged 1 commit intomasterfrom Oct 25, 2017
Merged
Conversation
nathansobo
approved these changes
Oct 23, 2017
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a discussion in the #atom-maintainers channel, this PR removes
package-lock.jsonfrom the repo and tells git to ignorepackage-lock.json.Since apm doesn't currently use
package-lock.json, it can be misleading to think that the versions specified inpackage-lock.jsonwill be the versions used when the package is installed by an Atom user. By excludingpackage-lock.jsonfrom the repo, we avoid this potential confusion.If apm gains the ability to use
package-lock.jsonin the future, we should start checking inpackage-lock.jsonat that point.