Conversation
|
I would be happy to update the readme in atom/welcome to correctly update the new behavior. |
|
You appear to have broken every single spec-please fix those or this can't get merged. I also fixed some of your issue linking to go to the correct repo. |
|
@50Wliu In atom/atom, npm test dies for me like so: apm test seems to pass, but doesn't test the packages. When I try to run specs inside atom itself, I get: How do I run tests for this package? |
|
In case anyone else has the same problem, just call
|
|
We have a PR out for a wider consent system (stored in core, activated in the welcome package) that allows both the metrics package and the exception-reporting package to read and act on the value. |
Changes metrics to only send exceptions by default. Adds two config options to the metrics package to toggle sending exceptions/other info.
See #25, atom/atom#5045, atom/atom#4966, #16, #38, atom/atom#5669