Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Sane Defaults on Reporting:#41

Closed
kans wants to merge 2 commits intoatom:masterfrom
kans:sane-defaults
Closed

Sane Defaults on Reporting:#41
kans wants to merge 2 commits intoatom:masterfrom
kans:sane-defaults

Conversation

@kans
Copy link

@kans kans commented Feb 22, 2015

Changes metrics to only send exceptions by default. Adds two config options to the metrics package to toggle sending exceptions/other info.

See #25, atom/atom#5045, atom/atom#4966, #16, #38, atom/atom#5669

Changes metrics to only send exceptions by default.  Adds two config options to the metrics package to toggle sending exceptions/other info.
See atom#25, #5045, #4966, atom#16, atom#38, #5669
@kans
Copy link
Author

kans commented Feb 22, 2015

I would be happy to update the readme in atom/welcome to correctly update the new behavior.

@winstliu
Copy link
Contributor

You appear to have broken every single spec-please fix those or this can't get merged.

I also fixed some of your issue linking to go to the correct repo.

@kans
Copy link
Author

kans commented Feb 22, 2015

@50Wliu
Is there any documentation on running tests? There is no test runner for metrics (it looks like only integration tests exist).

In atom/atom, npm test dies for me like so:

> node script/test

Node: v1.2.0
npm: v2.5.1
Installing build modules...
Installing apm...
Installing modules ✓
Deduping modules ✓
/bin/sh: node_modules/.bin/grunt: No such file or directory

apm test seems to pass, but doesn't test the packages.

When I try to run specs inside atom itself, I get:

 Error: Failed to execute 'registerElement' on 'Document': Registration failed for type 'atom-pane'. A type with that name is already registered.
  at Error (native)
  at Object.<anonymous> (src/pane-element.coffee:132:41)

How do I run tests for this package?

@kans
Copy link
Author

kans commented Feb 22, 2015

In case anyone else has the same problem, just call

apm test in the directory of the package.

@damieng
Copy link
Contributor

damieng commented Aug 2, 2016

We have a PR out for a wider consent system (stored in core, activated in the welcome package) that allows both the metrics package and the exception-reporting package to read and act on the value.

#66

@damieng damieng closed this Aug 2, 2016
@ghost ghost mentioned this pull request Jan 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants