This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add a lookahead for DELETE to avoid mistaking HTTP strings for SQL#315
Merged
darangi merged 3 commits intoatom:masterfrom Jan 27, 2021
illright:fix/mistaken-sql
Merged
Add a lookahead for DELETE to avoid mistaking HTTP strings for SQL#315darangi merged 3 commits intoatom:masterfrom illright:fix/mistaken-sql
darangi merged 3 commits intoatom:masterfrom
illright:fix/mistaken-sql
Conversation
|
Thanks for your submission! We require automated tests for all pull requests that include new or changed code. We do this so that we can ensure that we don't accidentally break your shiny new code the next time we or some other contributor submits a change. If you need help writing automated tests for Atom, check out Discuss, the official Atom and Electron message board or join the Atom Slack team. There are a bunch of helpful community members that should be willing to point you in the right direction. |
Contributor
Author
|
@calebmeyer Could you please take a look at the latest failing build? I don't think it's failing because of my changes |
Contributor
|
Thanks @illright for your contribution, The failure isn't related to your change, this is a problem with Travis service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently, the uppercase
DELETEis a trigger to initiate coloring for embedded SQL. That comes into conflict with the HTTP request descriptions, whereDELETEis one of the allowed methods.So an API-describing string like:
starts getting wrong highlighting starting from the DELETE keyword.
This PR aims to cover this particular case of the occurence of
DELETEin a string.Benefits
API descriptions in Python strings will look more appealing, and provided that servers are frequently written in Python, this is a considerable use case.
Possible Drawbacks
Looks a little hacky.