This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add generic system font families#169
Merged
lee-dohm merged 1 commit intoatom:masterfrom May 14, 2020
tysongach:system-fonts
Merged
Add generic system font families#169lee-dohm merged 1 commit intoatom:masterfrom tysongach:system-fonts
lee-dohm merged 1 commit intoatom:masterfrom
tysongach:system-fonts
Conversation
This adds support for the following generic font families, which were added to the [CSS Fonts Module Level 4][css-fonts-level-4]: - `system-ui` - `ui-monospace` - `ui-rounded` - `ui-sans-serif` - `ui-serif` [css-fonts-level-4]: https://drafts.csswg.org/css-fonts-4/
Contributor
|
Thanks for adding this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This adds support for the following generic font families, which were added to the CSS Fonts Module Level 4:
system-uiui-monospaceui-roundedui-sans-serifui-serifAlternate Designs
Not applicable.
Benefits
Atom users will see these values properly syntax-highlighted like they do with
serif,sans-serif, and other generic font family keyword values.Possible Drawbacks
While
system-uiis well-supported,ui-monospace,ui-rounded,ui-sans-serif, andui-serifare newer and less supported.Applicable Issues
I couldn’t find any.