This repository was archived by the owner on Dec 15, 2022. It is now read-only.
⬆️ keyboard-layout@2.0.17 (and rename deprecated "prepublish" script to "prepare")#250
Merged
sadick254 merged 2 commits intoatom:masterfrom Jul 6, 2021
Merged
Conversation
Fixes compilation on Windows 32-bit against Electron 11, by adding a compilation warning to the list of ignored ones. (Compilation for this package is configures to hard error out for non-ignored warnings.)
64 tasks
Contributor
Author
|
Unrelated, but I recommend renaming the https://github.com/atom/atom-keymap/blob/v8.2.14/package.json#L7 I can add that to this PR if you want, or open another PR. But it's a pretty simple edit. |
Contributor
|
@DeeDeeG you can add it to this PR no problem. |
The npm lifecycle script "prepublish" has been deprecated for a long time. In npm 7, it doesn't run before `npm publish`, only during `npm install` or `npm ci` building this package locally. The "prepare" lifecycle script does what "prepublish" used to do. See: https://docs.npmjs.com/cli/v7/using-npm/scripts
Contributor
Author
|
@sadick254 okay, I pushed the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Bump the
keyboard-layoutpackage to version 2.0.17.Alternate Designs
Fix the code warning in the
keyboard-layoutpackage, I guess.Benefits
Includes atom/keyboard-layout#59, which allows the module to compile on Windows 32-bit against Electron 10 and newer, by ignoring a compilation warning that would otherwise be treated as a hard error.
Possible Drawbacks
None, unless that compilation warning was important. 🤷
Applicable Issues