This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Remove if (reason === crashed)#23158
Merged
sadick254 merged 1 commit intoatom:masterfrom Nov 18, 2021
icecream17:patch-8
Merged
Remove if (reason === crashed)#23158sadick254 merged 1 commit intoatom:masterfrom icecream17:patch-8
if (reason === crashed)#23158sadick254 merged 1 commit intoatom:masterfrom
icecream17:patch-8
Conversation
Although `crashed` has recently been updated to `render-process-gone`, the new params don't actually have to be used. In fact maybe allowing some of the other crash-ishes could result in weird invalid state and things happening. So basically I agree with #23132 (comment) Maybe there should be a different message for the `killed` reason though
Contributor
|
This PR gets a 👍 from me (of course, it was my suggestion), because this restores the crash handling behavior to how it was before #23132. Without this PR, there are several Maybe we can use the |
sadick254
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
crashedhas recently been updated torender-process-gone, the new params don't actually have to be used. In fact maybe allowing some of the other crash-ishes could result in weird invalid state and things happening. So basically I agree with #23132 (comment)Maybe there should be a different message for the
killedreason though