This repository was archived by the owner on Mar 3, 2023. It is now read-only.
git-diff: Fix typo in code #22543
Merged
git-diff: Fix typo in code #22543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icecream17
approved these changes
Jun 4, 2021
sadick254
approved these changes
Jun 4, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
Looks great. Congratulations on your first contribution to atom. 🎉
Contributor
Author
|
Update: also fixes #22532 |
1 task
|
@sadick254 @icecream17 Here are all the related issues we found: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Description of the Change
A typo inside the function
subscribeToRepositorywas causing the mentioned TypeError because the variablethis.edtiorwas undefined. Changing it tothis.editorfixes the error.Alternate Designs
None.
Possible Drawbacks
None.
Verification Process
After this change,
subscribeToRepositoryno longer throws an error when called, e.g. when following the steps to reproduce the issue.Release Notes