This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs#22315
Merged
sadick254 merged 6 commits intoatom:masterfrom May 12, 2021
Merged
Replaced OS X Yosemite-era icon with macOS Big Sur icon for Atom for Macs#22315sadick254 merged 6 commits intoatom:masterfrom
sadick254 merged 6 commits intoatom:masterfrom
Conversation
|
Thank you! It looks beautiful! |
sadick254
reviewed
May 11, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
This looks really good. I would be glad if you could also add icons for nightly and beta versions of Atom.
sadick254
reviewed
May 12, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
Is there a reason for deleting beta/atom.icns
Contributor
Author
|
|
sadick254
approved these changes
May 12, 2021
|
I want to invest in your company 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue or RFC Endorsed by Atom's Maintainers
#21128
Description of the Change
I replaced the older default icon for Atom with the Big Sur-style icon for Atom for Macs only. Windows icons is still the same.
Alternate Designs
Possible Drawbacks
Verification Process
The verification process is not needed, as this is just an icon swap with the same file extension (between the icon being replaced and replacement icon).
Release Notes
The app icon on macOS has been changed to reflect the style in macOS Big Sur.