Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Bump version of language-css#21955

Closed
cssinate wants to merge 1 commit intoatom:masterfrom
cssinate:master
Closed

Bump version of language-css#21955
cssinate wants to merge 1 commit intoatom:masterfrom
cssinate:master

Conversation

@cssinate
Copy link

@cssinate cssinate commented Feb 11, 2021

Identify the Bug

#21954

Description of the Change

Bumping version of language-css from 0.44.4 to 0.44.5

Alternate Designs

Possible Drawbacks

Verification Process

All tests passed in language-css

Release Notes

N/A

Comment on lines +4739 to 4740
"version": "https://www.atom.io/api/packages/language-css/versions/0.44.5/tarball",
"integrity": "sha512-BBlnxUx9SCv+mIYOBWUApvyB/rSOewy2m8g6f3Vk2LfLf0+t8+Hcay5hWqXqpyKS4BUa15E3TVhl3PHEpqwZ1w==",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the version bump for this package, I'd expect the SHA512sum in the "integrity" field to be updated as well.

You can run npm install --package-lock-only in the root of the atom repo to update the SHA512sum/integrity field.

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Feb 14, 2021

I have a commit (DeeDeeG@99afd50) that fixes the package-lock.json. But there is now a failing test, so there is some work left beyond that.

@cssinate I can make my own PR here at the main Atom repo to continue working on this, or I can open a PR at your fork to add just my commit to this PR's branch. I'll lean toward making my own PR here if no response.

@cssinate
Copy link
Author

cssinate commented Feb 14, 2021 via email

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Feb 14, 2021

I opened #21963. You can subscribe on the sidebar of that issue if you want notifications of any updates with that. (Or you can deliberately not do that to keep your inbox clean!!)

I do hope the failing test can be figured out and this can land land to fix the code highlighting. Thanks for getting the ball rolling!

@sadick254
Copy link
Contributor

I'm going to close this since there is a similar PR to bump language-css package. As @DeeDeeG suggested you can subscribe to changes on #21963.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants