This repository was archived by the owner on Mar 3, 2023. It is now read-only.
check if testRunner is es module#21715
Merged
darangi merged 2 commits intoatom:masterfrom Dec 11, 2020
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
UziTech
commented
Nov 18, 2020
| TextEditor.setClipboard(clipboard); | ||
| TextEditor.viewForItem = (item) => atom.views.getView(item); | ||
|
|
||
| const testRunner = requireModule(testRunnerPath); |
Contributor
Author
There was a problem hiding this comment.
using requireModule instead of require here is the only change other than decaffeinating the file.
838d332 to
90839c0
Compare
90839c0 to
bd544cf
Compare
Contributor
|
Thanks @UziTech |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy of #21661 but using #21112
Identify the Bug
If the
atomTestRunneris transpiled by typescript or anything else usingatomTranspilersinto an ES module the test runner will not run.https://github.com/UziTech/terminal/blob/a116a214b6690390dfa656f61813c0596ba7523e/package.json#L30-L36
Description of the Change
set
testRunnertotestRunner.defaultiftestRunner.__esModuleis set totrue;Alternate Designs
Possible Drawbacks
none
Verification Process
compiled Atom and with this fix and tested the code at https://github.com/UziTech/terminal/tree/custom-runner-ts
Release Notes
Allow
atomTestRunnerto point to an ES Module