This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Use the built-in Visual Studio instead of windows-build-tools v4#21379
Merged
sadick254 merged 3 commits intoatom:masterfrom Apr 29, 2021
Merged
Use the built-in Visual Studio instead of windows-build-tools v4#21379sadick254 merged 3 commits intoatom:masterfrom
sadick254 merged 3 commits intoatom:masterfrom
Conversation
Windows-build-tools v4 (which is an old unmaintaind version) installs Visual Studio 2015. But we can use the pre-installed 2017 in vs2017-win2016 Requires atom/apm#892
sadick254
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires atom/apm#892-> doneDescription of the change
Windows-build-tools v4 (which is an old unmaintained version) installs Visual Studio 2015. But we can use the pre-installed 2017 in vs2017-win2016 Microsoft agents.
Benefits
Using Visual Studio 2017 has many benefits:
Verification
The CI passes. We have been using this for a long time in our community version:
https://github.com/atom-ide-community/atom
Release Notes