This repository was archived by the owner on Mar 3, 2023. It is now read-only.
RFC: Grammar comment delims #18816
Merged
RFC: Grammar comment delims #18816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It's great when the tests fail without any changes /s |
sadick254
reviewed
Jun 4, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
Good explanation on the RFC. This looks good only one suggestion.
sadick254
approved these changes
Sep 3, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
I would love to see this work implemented in future. 👍
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy for packages to get the correct comment delimiters for an arbitrary grammar.
View rendered docs/rfcs/005-grammar-comment-delims.md