This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Update windows atom.sh launch script to support WSL changes in 1809 #18703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solvaholic
reviewed
May 12, 2019
| eval $(grep "^root" /etc/wsl.conf | sed -e "s/ //g") | ||
| root="$(echo $root | sed 's|/|\\/|g')" | ||
| ATOMCMD="$(echo $PWD | sed 's/\/mnt\/\([a-z]*\)\(.*\)/\1:\2/')/atom.cmd" | ||
| ATOMCMD="${ATOMCMD////\\}" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#18702
Description of the Change
Change windows atom.sh launcher to:
Alternate Designs
Could potentially format the path in a way that was friendly for the original Cygwin launch method
Possible Drawbacks
Potentially breaks on previous builds of Windows, although I don't have the facilities to test
Verification Process
Repeated the steps outlined in the linked issue and atom launched as expected.
Release Notes