This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Migrate core package 'grammar-selector' into ./packages#18256
Merged
maxbrunsfeld merged 2 commits intomasterfrom Oct 18, 2018
Merged
Migrate core package 'grammar-selector' into ./packages#18256maxbrunsfeld merged 2 commits intomasterfrom
maxbrunsfeld merged 2 commits intomasterfrom
Conversation
daviwil
approved these changes
Oct 17, 2018
packages/README.md
Outdated
| | **git-diff** | [`./git-diff`](./git-diff) | [#17843](https://github.com/atom/atom/issues/17843) | | ||
| | **go-to-line** | [`./go-to-line`](./go-to-line) | [#17844](https://github.com/atom/atom/issues/17844) | | ||
| | **grammar-selector** | [`atom/grammar-selector`][grammar-selector] | [#17845](https://github.com/atom/atom/issues/17845) | | ||
| | **grammar-selector** | [`./packages/grammar-selector`](./grammar-selector) | [#17845](https://github.com/atom/atom/issues/17845) | |
Contributor
There was a problem hiding this comment.
The path in the link text should be ./grammar-selector, that's something we changed since the earlier versions of the migration steps (I wrote it wrong in the steps 😁)
Contributor
Author
There was a problem hiding this comment.
Oh yeah, thanks for catching that!
Contributor
Author
|
This went green when I rebuilt, but it didn't update the PR status. |
Contributor
|
VSTS has a "Rebuild" action hidden in the "..." menu, that's the one you'll want to use to rebuild PRs. Running it with Queue doesn't cause the check state to be updated 😕 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17845