This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Remove unused package-lock.json files before building#16493
Merged
Conversation
|
Great! You also could call it |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
package-lock.jsonfiles are generated by the build on certain configurations. When they are, they can sometimes create strange, hard-to-diagnose errors that prevent successive builds. This change deletes thepackage-lock.jsonfiles (that we don't use for Atom) before building so that people who aren't consistently building Atom don't get confused.Alternate Designs
Considered actually using the
package-lock.jsonfiles but we're not ready to do that yet.Why Should This Be In Core?
Because that's where builds happen.
Benefits
Easier build experience for everyone 🎉
Possible Drawbacks
We'll have to rip this out if/when we decide to use
package-lock.jsonfiles.Applicable Issues
None known?