Enable default editor keymaps for editors located outside atom-workspace by as-cii · Pull Request #16206 · atom/atom

as-cii · 2017-11-16T08:15:14Z

This is similar to what we do for macOS keymaps:

Lines 108 to 163 in 6cbc998

    
           'atom-text-editor': 
        
             # Platform Bindings 
        
             'alt-left': 'editor:move-to-beginning-of-word' 
        
             'alt-right': 'editor:move-to-end-of-word' 
        
             'alt-shift-left': 'editor:select-to-beginning-of-word' 
        
             'alt-shift-right': 'editor:select-to-end-of-word' 
        
             # Apple Specific 
        
             'cmd-backspace': 'editor:delete-to-beginning-of-line' 
        
             'cmd-shift-backspace': 'editor:delete-to-beginning-of-line' 
        
             'cmd-delete': 'editor:delete-to-end-of-line' 
        
             'ctrl-shift-a': 'editor:select-to-first-character-of-line' 
        
             'ctrl-shift-e': 'editor:select-to-end-of-line' 
        
             'cmd-left': 'editor:move-to-first-character-of-line' 
        
             'cmd-right': 'editor:move-to-end-of-screen-line' 
        
             'cmd-shift-left': 'editor:select-to-first-character-of-line' 
        
             'cmd-shift-right': 'editor:select-to-end-of-line' 
        
             'alt-backspace': 'editor:delete-to-beginning-of-word' 
        
             'alt-delete': 'editor:delete-to-end-of-word' 
        
             'ctrl-a': 'editor:move-to-first-character-of-line' 
        
             'ctrl-e': 'editor:move-to-end-of-line' 
        
             'ctrl-k': 'editor:cut-to-end-of-line' 
        
             # Atom Specific 
        
             'ctrl-shift-w': 'editor:select-word' 
        
             'cmd-ctrl-left': 'editor:move-selection-left' 
        
             'cmd-ctrl-right': 'editor:move-selection-right' 
        
             'cmd-shift-V': 'editor:paste-without-reformatting' 
        
             # Emacs 
        
             'alt-f': 'editor:move-to-end-of-word' 
        
             'alt-ctrl-f': 'editor:move-to-next-subword-boundary' 
        
             'alt-shift-f': 'editor:select-to-end-of-word' 
        
             'alt-ctrl-shift-f': 'editor:select-to-next-subword-boundary' 
        
             'alt-b': 'editor:move-to-beginning-of-word' 
        
             'alt-ctrl-b': 'editor:move-to-previous-subword-boundary' 
        
             'alt-shift-b': 'editor:select-to-beginning-of-word' 
        
             'alt-ctrl-shift-b': 'editor:select-to-previous-subword-boundary' 
        
             'alt-h': 'editor:delete-to-beginning-of-word' 
        
             'alt-ctrl-h': 'editor:delete-to-beginning-of-subword' 
        
             'alt-d': 'editor:delete-to-end-of-word' 
        
             'alt-ctrl-d': 'editor:delete-to-end-of-subword' 
        
             # Sublime Parity 
        
             'cmd-a': 'core:select-all' 
        
             'cmd-alt-p': 'editor:log-cursor-scope' 
        
             'cmd-k cmd-u': 'editor:upper-case' 
        
             'cmd-k cmd-l': 'editor:lower-case' 
        
             'cmd-l': 'editor:select-line' 
        
             'ctrl-t': 'editor:transpose' 
        
             'ctrl-alt-left': 'editor:move-to-previous-subword-boundary' 
        
             'ctrl-alt-right': 'editor:move-to-next-subword-boundary' 
        
             'ctrl-alt-shift-left': 'editor:select-to-previous-subword-boundary' 
        
             'ctrl-alt-shift-right': 'editor:select-to-next-subword-boundary' 
        
             'ctrl-alt-backspace': 'editor:delete-to-beginning-of-subword' 
        
             'ctrl-alt-delete': 'editor:delete-to-end-of-subword'

And would fix an issue teletype users are noticing when using editor commands in the popover. Since the popover is located outside the workspace (i.e. because it is a tooltip), keyboard shortcuts are not working for Linux and Windows users. I assume this is an issue with every package that attempts to use an editor outside the atom-workspace element.

@atom/maintainers: what do you think?

/cc: @AlexWayfer, who originally reported the issue on atom/teletype.

jasonrudolph · 2017-11-16T14:44:14Z

@as-cii: Would this also fix atom/teletype#102?

as-cii · 2017-11-16T14:58:02Z

I don't think it would because in that circumstance we use a native input element, as opposed to an atom-text-editor. Fixing that problem should be pretty easy though; I think it should only be a matter of using the native-keybindings class on the input element.

nathansobo · 2017-11-17T03:16:21Z

We should really find a way to fall back to native bindings as a default instead of requiring that class.

sadick254

Tested on my local windows and Linux installation. Looks good.

mrknutsen approved these changes Mar 16, 2019

View reviewed changes

Enable default editor keymaps for editors located outside atom-workspace

fb338da

sadick254 force-pushed the as-enable-editor-keymaps-outside-workspace-on-linux-and-win32 branch from 7958961 to fb338da Compare May 21, 2021 16:29

sadick254 approved these changes May 21, 2021

View reviewed changes

sadick254 merged commit ede1f91 into master May 21, 2021

sadick254 deleted the as-enable-editor-keymaps-outside-workspace-on-linux-and-win32 branch May 21, 2021 20:13

renovate bot mentioned this pull request Jul 28, 2021

fix(package): fix integration test failure for atom-beta version v1.61.0-beta0 smhxx/atom-ts-transpiler#83

Closed

1 task

This comment has been minimized.

Sign in to view

This was referenced Oct 31, 2021

> Fixes [atom/teletype#208](https://github.com/atom/teletype/issues/208) #23173

Closed

> > Fixes [atom/teletype#208](https://github.com/atom/teletype/issues/208) #23174

Closed

This comment has been minimized.

Sign in to view

atom deleted a comment from Floy288 Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable default editor keymaps for editors located outside atom-workspace#16206

Enable default editor keymaps for editors located outside atom-workspace#16206
sadick254 merged 1 commit intomasterfrom
as-enable-editor-keymaps-outside-workspace-on-linux-and-win32

as-cii commented Nov 16, 2017

Uh oh!

jasonrudolph commented Nov 16, 2017

Uh oh!

as-cii commented Nov 16, 2017

Uh oh!

nathansobo commented Nov 17, 2017

Uh oh!

sadick254 left a comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	'atom-text-editor':
	# Platform Bindings
	'alt-left': 'editor:move-to-beginning-of-word'
	'alt-right': 'editor:move-to-end-of-word'
	'alt-shift-left': 'editor:select-to-beginning-of-word'
	'alt-shift-right': 'editor:select-to-end-of-word'

	# Apple Specific
	'cmd-backspace': 'editor:delete-to-beginning-of-line'
	'cmd-shift-backspace': 'editor:delete-to-beginning-of-line'
	'cmd-delete': 'editor:delete-to-end-of-line'
	'ctrl-shift-a': 'editor:select-to-first-character-of-line'
	'ctrl-shift-e': 'editor:select-to-end-of-line'
	'cmd-left': 'editor:move-to-first-character-of-line'
	'cmd-right': 'editor:move-to-end-of-screen-line'
	'cmd-shift-left': 'editor:select-to-first-character-of-line'
	'cmd-shift-right': 'editor:select-to-end-of-line'
	'alt-backspace': 'editor:delete-to-beginning-of-word'
	'alt-delete': 'editor:delete-to-end-of-word'
	'ctrl-a': 'editor:move-to-first-character-of-line'
	'ctrl-e': 'editor:move-to-end-of-line'
	'ctrl-k': 'editor:cut-to-end-of-line'

	# Atom Specific
	'ctrl-shift-w': 'editor:select-word'
	'cmd-ctrl-left': 'editor:move-selection-left'
	'cmd-ctrl-right': 'editor:move-selection-right'
	'cmd-shift-V': 'editor:paste-without-reformatting'

	# Emacs
	'alt-f': 'editor:move-to-end-of-word'
	'alt-ctrl-f': 'editor:move-to-next-subword-boundary'
	'alt-shift-f': 'editor:select-to-end-of-word'
	'alt-ctrl-shift-f': 'editor:select-to-next-subword-boundary'
	'alt-b': 'editor:move-to-beginning-of-word'
	'alt-ctrl-b': 'editor:move-to-previous-subword-boundary'
	'alt-shift-b': 'editor:select-to-beginning-of-word'
	'alt-ctrl-shift-b': 'editor:select-to-previous-subword-boundary'
	'alt-h': 'editor:delete-to-beginning-of-word'
	'alt-ctrl-h': 'editor:delete-to-beginning-of-subword'
	'alt-d': 'editor:delete-to-end-of-word'
	'alt-ctrl-d': 'editor:delete-to-end-of-subword'

	# Sublime Parity
	'cmd-a': 'core:select-all'
	'cmd-alt-p': 'editor:log-cursor-scope'
	'cmd-k cmd-u': 'editor:upper-case'
	'cmd-k cmd-l': 'editor:lower-case'
	'cmd-l': 'editor:select-line'
	'ctrl-t': 'editor:transpose'
	'ctrl-alt-left': 'editor:move-to-previous-subword-boundary'
	'ctrl-alt-right': 'editor:move-to-next-subword-boundary'
	'ctrl-alt-shift-left': 'editor:select-to-previous-subword-boundary'
	'ctrl-alt-shift-right': 'editor:select-to-next-subword-boundary'
	'ctrl-alt-backspace': 'editor:delete-to-beginning-of-subword'
	'ctrl-alt-delete': 'editor:delete-to-end-of-subword'

Conversation

as-cii commented Nov 16, 2017

Uh oh!

jasonrudolph commented Nov 16, 2017

Uh oh!

as-cii commented Nov 16, 2017

Uh oh!

nathansobo commented Nov 17, 2017

Uh oh!

sadick254 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants