This repository was archived by the owner on Mar 3, 2023. It is now read-only.
📝 Clarify that stack only has an effect if detail is present as well#13821
Merged
📝 Clarify that stack only has an effect if detail is present as well#13821
Conversation
f2dcffb to
f2c63d8
Compare
Contributor
|
Hey @50Wliu. Apologies for not looking into this on time. I know this PR has been here for a very long time, during that time Atom has seen a number of changes. Due to the changes, this PR has now become outdated. Is it possible for you to resolve the conflicts? |
Contributor
Author
|
Yes, of course! |
Contributor
Author
|
7401 commits! That must be a record for me 😄 |
sadick254
reviewed
Sep 3, 2021
Contributor
sadick254
left a comment
There was a problem hiding this comment.
@50Wliu Thank you for resolving the conflicts. I appreciate your efforts.
sadick254
approved these changes
Sep 3, 2021
|
{"message":"Missing Authentication Token"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Lost quite a bit of time on this until I poked around in notification-element's source code and discovered that supplying
stackwon't do anything unlessdetailis also specified.Alternate Designs
Stack could be made independent of detail, but that would require HTML/CSS changes in atom/notifications.
Why Should This Be In Core?
Documentation change.
Applicable Issues
Goes hand-in-hand with atom/notifications#148