This repository was archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17.3k
This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Atom Electron 9 CLI disconnects after running commands and never exits #22024
Copy link
Copy link
Open
Description
Prerequisites
Prerequisites
- Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
Running CLI commands using Atom Electron 9 doesn't work like previous versions. For example, running atom --version it first exists, and then prints to the shell:
aminy@LAPTOP-DHBEBJRL ~\Documents\GitHub\JavaScript\atom-dev [22:06]
❯ ./atom-dev --version
aminy@LAPTOP-DHBEBJRL ~\Documents\GitHub\JavaScript\atom-dev [22:06]
❯
Atom : 1.57.0-dev-9887b306
Electron: 9.4.4
Chrome : 83.0.4103.122
Node : 12.14.1
Also, no matter how much you wait, it never exits, and stopping with CTRL+C creates this mess:
If you run atom --test spec a lot of additional errors are issued to the command line which shouldn't for the end-users (we should suppress these warnings somehow):
aminy@LAPTOP-DHBEBJRL ~\Documents\GitHub\JavaScript\@atom-ide-community\atom-ide-outline master ↓2 [22:11]
❯ C:/Users/aminy/Documents/GitHub/JavaScript/atom-dev/atom-dev.exe --test spec
aminy@LAPTOP-DHBEBJRL ~\Documents\GitHub\JavaScript\@atom-ide-community\atom-ide-outline
master ↓2 [22:11]
❯ (node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\pathwatcher\build\Release\pathwatcher.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\oniguruma\build\Release\onig_scanner.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\superstring\build\Release\superstring.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\tree-sitter\build\Release\tree_sitter_runtime_binding.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\@atom\nsfw\build\Release\nsfw.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\git-utils\build\Release\git.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
(node:18520) Electron: Loading non-context-aware native module in renderer: '\\?\C:\Users\aminy\Documents\GitHub\JavaScript\atom-dev\resources\app.asar.unpacked\node_modules\scrollbar-style\build\Release\scrollbar-style-observer.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
.........
9 specs, 0 failures
Finished in 2.454 secondsIf you force-exit atom --test spec after finishing, it will not actually exit, but it prints this. The only way is to close the terminal
[process exited with code 3762504530]Steps to Reproduce
- Run cli commands using Atom-dev such as
atom --versionoratom --test spec
Expected behavior:
CLI command should stay connected and exit with 0 code afterward.
Actual behavior:
CLI disconnects and never exits.
Reproduces how often:
Always
Versions
Atom : 1.57.0-dev-9887b306
Electron: 9.4.4
Chrome : 83.0.4103.122
Node : 12.14.1
Additional Information
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels

