This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
26 tasks
Contributor
Author
|
@as-cii I removed |
Contributor
Great catch, @simurai! ✨ I have updated this pull request's description with a link of the first-mate pull request we'll need to merge in order to address this. Thanks! |
d898626 to
84f4310
Compare
Contributor
|
Tests are failing, but this seems to be the case on master as well. I'll go ahead and 🚢 this, as it's blocking the shadow DOM removal pull request. Thanks, @simurai! |
This was referenced Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are in the process of removing the shadow DOM boundary from
atom-text-editorelements. This pull request upgrades existing selectors so that they::host.atom-text-editor::shadow.syntax--.TODO
templates/theme):hostfrom TextMate converter (src/text-mate-theme.coffee)syntax--when converting TextMate themes (UpdatescopeSelector.toCss()to return prefixed syntax selectors first-mate#80)