Skip to content

fix validation#1

Merged
atlv24 merged 1 commit intoatlv24:ray-tracingfrom
Vecvec:ray-tracing-fix-validation
May 1, 2024
Merged

fix validation#1
atlv24 merged 1 commit intoatlv24:ray-tracingfrom
Vecvec:ray-tracing-fix-validation

Conversation

@Vecvec
Copy link
Copy Markdown

@Vecvec Vecvec commented Apr 26, 2024

Connections
fixes validation messages from vulkan by transitioning the tlas instance buffer

Description
adds a extra line to tlas instance transition buffer, fixes validation errors about WRITE_AFTER_WRITE

Testing
tested with ray cube compute
before:
log filled with

        Validation Error: [ SYNC-HAZARD-WRITE-AFTER-WRITE ] Object 0: handle = 0x21887baf5f0, type = VK_OBJECT_TYPE_QUEUE; | MessageID = 0x5c0ec5d6 | vkQueueSubmit():  Hazard WRITE_AFTER_WRITE for entry 1, VkCommandBuffer 0x2189
45073d0[], Submitted access info (submitted_usage: SYNC_COPY_TRANSFER_WRITE, command: vkCmdCopyBuffer, seq_no: 3, reset_no: 1). Access info (prior_usage: SYNC_COPY_TRANSFER_WRITE, write_barriers: SYNC_VERTEX_SHADER_ACCELERATION_
STRUCTURE_READ|SYNC_FRAGMENT_SHADER_ACCELERATION_STRUCTURE_READ|SYNC_COMPUTE_SHADER_ACCELERATION_STRUCTURE_READ|SYNC_ACCELERATION_STRUCTURE_BUILD_ACCELERATION_STRUCTURE_READ|SYNC_ACCELERATION_STRUCTURE_BUILD_ACCELERATION_STRUCTURE_WRITE, queue: VkQueue 0x21887baf5f0[], submit: 1, batch: 0, batch_tag: 27, command: vkCmdCopyBuffer, command_buffer: VkCommandBuffer 0x218944ec2b0[], seq_no: 3, reset_no: 3).
[2024-04-26T05:46:16Z ERROR wgpu_hal::vulkan::instance]         objects: (type: QUEUE, hndl: 0x21887baf5f0, name: ?)
[2024-04-26T05:46:16Z ERROR wgpu_hal::vulkan::instance] VALIDATION [SYNC-HAZARD-WRITE-AFTER-WRITE (0x5c0ec5d6)]

after:

[2024-04-26T06:25:53Z INFO  wgpu_examples::framework] Surface resize PhysicalSize { width: 1424, height: 714 }
[2024-04-26T06:25:53Z INFO  wgpu_examples::framework] Surface resize PhysicalSize { width: 800, height: 600 }
[2024-04-26T06:25:53Z INFO  wgpu_examples::framework] Surface resize PhysicalSize { width: 800, height: 600 }
[2024-04-26T06:25:54Z INFO  wgpu_examples::framework] Frame time 9.49ms (105.4 FPS)
[2024-04-26T06:25:55Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:25:56Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:25:57Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:25:58Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:25:59Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:26:00Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)
[2024-04-26T06:26:01Z INFO  wgpu_examples::framework] Frame time 8.33ms (120.0 FPS)

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown done by github actions
    • --target wasm32-unknown-emscripten done by github actions
  • Run cargo xtask test to run tests. done by github actions
  • Add change to CHANGELOG.md. Part of the ray-tracing PR

@Vecvec Vecvec mentioned this pull request Apr 29, 2024
Closed
15 tasks
@atlv24 atlv24 merged commit 6166c86 into atlv24:ray-tracing May 1, 2024
@Vecvec Vecvec deleted the ray-tracing-fix-validation branch June 15, 2024 18:36
@Vecvec Vecvec restored the ray-tracing-fix-validation branch June 15, 2024 18:36
@Vecvec Vecvec deleted the ray-tracing-fix-validation branch June 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vecvec @atlv24