Skip to content

Bump PSR and reactivate styleci#980

Closed
romaninsh wants to merge 3 commits intodevelopfrom
feature/fix-PSRs
Closed

Bump PSR and reactivate styleci#980
romaninsh wants to merge 3 commits intodevelopfrom
feature/fix-PSRs

Conversation

@romaninsh
Copy link
Copy Markdown
Member

@romaninsh romaninsh commented Mar 12, 2020

just get styleci going again.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #980 into develop will increase coverage by 0.04%.
The diff coverage is 75.09%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #980      +/-   ##
=============================================
+ Coverage      71.41%   71.45%   +0.04%     
  Complexity      2663     2663              
=============================================
  Files            126      126              
  Lines           6255     6264       +9     
=============================================
+ Hits            4467     4476       +9     
  Misses          1788     1788
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/FilterModel/TypeDate.php 0% <0%> (ø) 14 <0> (ø) ⬇️
src/Text.php 50% <0%> (ø) 5 <0> (ø) ⬇️
src/FormField/TreeItemSelector.php 17.64% <0%> (ø) 13 <0> (ø) ⬇️
src/ActionExecutor/jsEvent.php 0% <0%> (ø) 23 <0> (ø) ⬇️
src/Exception/NoRenderTree.php 0% <0%> (ø) 2 <0> (ø) ⬇️
src/SSE.php 0% <0%> (ø) 27 <0> (ø) ⬇️
src/TableColumn/FilterModel/TypeString.php 33.33% <0%> (ø) 8 <0> (ø) ⬇️
src/ActionExecutor/jsArgumentForm.php 0% <0%> (ø) 12 <0> (ø) ⬇️
src/CRUD.php 57.69% <0%> (ø) 62 <0> (ø) ⬇️
src/TableColumn/FilterModel/TypeDatetime.php 0% <0%> (ø) 22 <0> (ø) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b86da...54f029c. Read the comment docs.

@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Mar 13, 2020 •
edited
Loading

Add CS fixer dev-dependency + rule file like in the core repo - https://github.com/atk4/core/blob/develop/.php_cs.dist

Preferably for all atk4 repos and with one/same rule file.

PSR-12 style should be prefered - the latest rules are here - PHP-CS-Fixer/PHP-CS-Fixer#4502 (comment)

@atk4 atk4 deleted a comment from update-docs bot Mar 18, 2020
@romaninsh
Copy link
Copy Markdown
Member Author

romaninsh commented Mar 18, 2020

I'll close this PR and will open new one due to conflicts. Easier this way. Just need to sort out #991.

@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Mar 18, 2020 •
edited
Loading

@romaninsh Why not to force-push this PR branch?

PR #991 is done.

@mvorisek mvorisek mentioned this pull request Mar 24, 2020
Closed
This was referenced Mar 27, 2020
Merged
Closed
@romaninsh romaninsh closed this Mar 30, 2020
@mvorisek mvorisek deleted the feature/fix-PSRs branch March 30, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@romaninsh romaninsh

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@romaninsh @mvorisek