Skip to content

Mistake in Exception message#975

Closed
TheNetworkIsDown wants to merge 1 commit intoatk4:developfrom
TheNetworkIsDown:patch-1
Closed

Mistake in Exception message#975
TheNetworkIsDown wants to merge 1 commit intoatk4:developfrom
TheNetworkIsDown:patch-1

Conversation

@TheNetworkIsDown
Copy link
Copy Markdown
Contributor

@TheNetworkIsDown TheNetworkIsDown commented Mar 8, 2020

The actual function to be called would be initLayout(), not setLayout(), which does not exist.

@TheNetworkIsDown
Mistake in Exception message
d4c52c0 
The actual function to be called would be initLayout(), not setLayout(), which does not exist.
@update-docs
Copy link
Copy Markdown

update-docs bot commented Mar 8, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2020 •
edited
Loading

Codecov Report

Merging #975 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #975   +/-   ##
==========================================
  Coverage      71.42%   71.42%           
  Complexity      2663     2663           
==========================================
  Files            126      126           
  Lines           6254     6254           
==========================================
  Hits            4467     4467           
  Misses          1787     1787
Impacted Files Coverage Δ Complexity Δ
src/App.php 79.16% <0%> (ø) 138 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f12bac...d4c52c0. Read the comment docs.

abbadon1334
abbadon1334 requested changes Mar 9, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@abbadon1334 abbadon1334 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch!
but now can be much better to divide the error from the solution like this :

$e = new Exception('App layout is missing');
$e->addSolution('If you use $app->add() you should first call $app->setLayout()');
throw $e;

DarkSide666
DarkSide666 approved these changes Mar 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are actually more mentions of setLayout in docs and source code. I will fix that too afterwards.
Thanks!

Edit: I will create and merge new PR instead of this because I'm unable to add anything to your branch. There should be more fixes there.

@DarkSide666 DarkSide666 closed this Mar 9, 2020
@DarkSide666 DarkSide666 mentioned this pull request Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbadon1334 abbadon1334 abbadon1334 requested changes

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheNetworkIsDown @DarkSide666 @abbadon1334