Fix unclickable Autocomplete/Lookup fields#808
Merged
ibelar merged 4 commits intoatk4:developfrom Oct 6, 2019
acicovic:feature/fix-autocomplete-lookup-click
Merged
Fix unclickable Autocomplete/Lookup fields#808ibelar merged 4 commits intoatk4:developfrom acicovic:feature/fix-autocomplete-lookup-click
ibelar merged 4 commits intoatk4:developfrom
acicovic:feature/fix-autocomplete-lookup-click
Conversation
ibelar
requested changes
Oct 6, 2019
Contributor
ibelar
left a comment
There was a problem hiding this comment.
Thanks! Good catch! But please update both .pug file accordingly.
Codecov Report
@@ Coverage Diff @@
## develop #808 +/- ##
==========================================
Coverage 76.28% 76.28%
Complexity 2294 2294
==========================================
Files 119 119
Lines 5414 5414
==========================================
Hits 4130 4130
Misses 1284 1284Continue to review full report at Codecov.
|
Collaborator
Author
|
@ibelar updated pug files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Autocomplete and Lookup controls, a large area of the control is unclickable, showing a hand cursor. This makes those controls effectively unusable.
The issue is reproducible in the current demo (for example https://ui.agiletoolkit.org/demos/autocomplete.php - hovering over Country1/2/3 towards the right will produce the hand cursor and unclickable control).
This PR fixes the issue for both controls.